Do not retrieve Blob metadata on batch delete #23650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
approved these changes
Oct 2, 2024
| getBlob(storage, new GcsLocation(location)) | ||
| .ifPresent(blob -> batch.delete(blob.getBlobId())); | ||
| GcsLocation gcsLocation = new GcsLocation(location); | ||
| batch.delete(BlobId.of(gcsLocation.bucket(), gcsLocation.path())); |
There was a problem hiding this comment.
I assume this does not throw if the blob does not exist.
There was a problem hiding this comment.
It doesn't throw:
Calling StorageBatchResult.get() on the return value yields true upon successful deletion, false if the blob was not found, or throws a StorageException if the operation failed.
findinpath
reviewed
Oct 3, 2024
| @@ -169,8 +169,8 @@ public void deleteFiles(Collection<Location> locations) | |||
| for (List<Location> locationBatch : partition(locations, batchSize)) { | |||
| StorageBatch batch = storage.batch(); | |||
| for (Location location : locationBatch) { | |||
| getBlob(storage, new GcsLocation(location)) | |||
There was a problem hiding this comment.
I'm curious, did you spot it by chance or was there a delete files in bulk slow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make batch delete way faster as it won't resolve blob metadata.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: